Approving PRs

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Approving PRs

Brian Stansberry
If you review a PR and it’s good, please use the Git Hub review feature to say so instead of just leaving a comment. That makes the fact that someone has approved it visible at a glance in the PR queue[1] which is nice and saves opening the issue and scrolling through comments, CI run reports etc.

When you look at the files of the PR, e.g. [2], in the top right there is the green “Review Changes” button. Click it, select Approve, add a comment if you like, and hit Submit.


[1] https://github.com/wildfly/wildfly-core/pulls
[2] https://github.com/wildfly/wildfly-core/pull/2326/files

Thanks,
--
Brian Stansberry
Manager, Senior Principal Software Engineer
JBoss by Red Hat




_______________________________________________
wildfly-dev mailing list
[hidden email]
https://lists.jboss.org/mailman/listinfo/wildfly-dev
Loading...