Closed/Reopened pull requests - github weirdness

classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

Closed/Reopened pull requests - github weirdness

kkhan
Due to the length of the pull queue and the number of requests that sit there for a while with a "negative" review awaiting further action from the committer I have started closing those asking people to reopen them. The intention of this was to have less noise for whoever is reviewing next.

However, we noticed this has some problems, the workflow is something like this:

-PR is submitted on xxxxx:branch_A with CommitA
-PR gets closed
-xxxx updates branch_A with CommitB and CommitC
-PR gets reopened
=>CommitB and CommitC are **NOT** visible in the PR
-xxxx updates branch_A with CommitD
=> CommitB, CommitC and CommitD are visible in the PR

So it seems like the pull request only polls for new commits while it is open. Anything committed when it was closed is invisible, until something else is committed once reopened.

I'm not sure what the best way to solve this is (unless we stop closing stuff), perhaps to never reopen but to create a new request with a link to the old one so the comments are visible?


_______________________________________________
jboss-as7-dev mailing list
[hidden email]
https://lists.jboss.org/mailman/listinfo/jboss-as7-dev
Reply | Threaded
Open this post in threaded view
|

Re: Closed/Reopened pull requests - github weirdness

kkhan
Github support got back to me, no promises to change this so far - just a request for clarification
On 16 Dec 2011, at 18:11, Kabir Khan wrote:

> Due to the length of the pull queue and the number of requests that sit there for a while with a "negative" review awaiting further action from the committer I have started closing those asking people to reopen them. The intention of this was to have less noise for whoever is reviewing next.
>
> However, we noticed this has some problems, the workflow is something like this:
>
> -PR is submitted on xxxxx:branch_A with CommitA
> -PR gets closed
> -xxxx updates branch_A with CommitB and CommitC
> -PR gets reopened
> =>CommitB and CommitC are **NOT** visible in the PR
> -xxxx updates branch_A with CommitD
> => CommitB, CommitC and CommitD are visible in the PR
>
> So it seems like the pull request only polls for new commits while it is open. Anything committed when it was closed is invisible, until something else is committed once reopened.
>
> I'm not sure what the best way to solve this is (unless we stop closing stuff), perhaps to never reopen but to create a new request with a link to the old one so the comments are visible?
>
>
> _______________________________________________
> jboss-as7-dev mailing list
> [hidden email]
> https://lists.jboss.org/mailman/listinfo/jboss-as7-dev


_______________________________________________
jboss-as7-dev mailing list
[hidden email]
https://lists.jboss.org/mailman/listinfo/jboss-as7-dev
Reply | Threaded
Open this post in threaded view
|

Re: Closed/Reopened pull requests - github weirdness

Ondrej Zizka
If you have the old PR opened and try to open a new PR on the same branch, an "Update Commit Range" dialog appears.
After updating, the new commits are added.  See https://github.com/jbossas/jboss-as/pull/925 .

Ondra




Kabir Khan píše v Po 19. 12. 2011 v 10:45 +0000:
Github support got back to me, no promises to change this so far - just a request for clarification
On 16 Dec 2011, at 18:11, Kabir Khan wrote:

> Due to the length of the pull queue and the number of requests that sit there for a while with a "negative" review awaiting further action from the committer I have started closing those asking people to reopen them. The intention of this was to have less noise for whoever is reviewing next.
> 
> However, we noticed this has some problems, the workflow is something like this:
> 
> -PR is submitted on xxxxx:branch_A with CommitA
> -PR gets closed
> -xxxx updates branch_A with CommitB and CommitC
> -PR gets reopened
> =>CommitB and CommitC are **NOT** visible in the PR
> -xxxx updates branch_A with CommitD
> => CommitB, CommitC and CommitD are visible in the PR
> 
> So it seems like the pull request only polls for new commits while it is open. Anything committed when it was closed is invisible, until something else is committed once reopened.
> 
> I'm not sure what the best way to solve this is (unless we stop closing stuff), perhaps to never reopen but to create a new request with a link to the old one so the comments are visible?
> 
> 
> _______________________________________________
> jboss-as7-dev mailing list
> [hidden email]
> https://lists.jboss.org/mailman/listinfo/jboss-as7-dev


_______________________________________________
jboss-as7-dev mailing list
[hidden email]
https://lists.jboss.org/mailman/listinfo/jboss-as7-dev

_______________________________________________
jboss-as7-dev mailing list
[hidden email]
https://lists.jboss.org/mailman/listinfo/jboss-as7-dev
Reply | Threaded
Open this post in threaded view
|

Re: Closed/Reopened pull requests - github weirdness

kkhan
To github:
I obviously don't know much about what goes on behind the scenes at github but an alternative thing to closing PRs needing more work, and then reopening would be a 'on hold' status or something - basically anything that works well which hides PRs needing more work from the main queue. The discussions on each PR get quite long sometimes so throwing it away and opening a new one isn't ideal since people normally forget to include the link to the original PR and try to sneak in new features :-)

Thanks,

Kabir
========
Reply:
/ Please reply above this line
==================================================
From: Petros Amiridis (GitHub Staff)
Subject: Fwd: Closed/Reopened pull requests - github weirdness

Hi Kabir, I have created an issue for the case you described, to see if we can do anything to improve it. Thank you very much for all the details and suggestions.

==================================================
Reply with #ignore to stop receiving notifications for this discussion.

-------

I've asked for a ticket

On 19 Dec 2011, at 14:18, Ondřej Žižka wrote:

> If you have the old PR opened and try to open a new PR on the same branch, an "Update Commit Range" dialog appears.
> After updating, the new commits are added.  See https://github.com/jbossas/jboss-as/pull/925 .
>
> Ondra
>
>
>
>
> Kabir Khan píše v Po 19. 12. 2011 v 10:45 +0000:
>> Github support got back to me, no promises to change this so far - just a request for clarification
>> On 16 Dec 2011, at 18:11, Kabir Khan wrote:
>>
>> > Due to the length of the pull queue and the number of requests that sit there for a while with a "negative" review awaiting further action from the committer I have started closing those asking people to reopen them. The intention of this was to have less noise for whoever is reviewing next.
>> >
>> > However, we noticed this has some problems, the workflow is something like this:
>> >
>> > -PR is submitted on xxxxx:branch_A with CommitA
>> > -PR gets closed
>> > -xxxx updates branch_A with CommitB and CommitC
>> > -PR gets reopened
>> > =>CommitB and CommitC are **NOT** visible in the PR
>> > -xxxx updates branch_A with CommitD
>> > => CommitB, CommitC and CommitD are visible in the PR
>> >
>> > So it seems like the pull request only polls for new commits while it is open. Anything committed when it was closed is invisible, until something else is committed once reopened.
>> >
>> > I'm not sure what the best way to solve this is (unless we stop closing stuff), perhaps to never reopen but to create a new request with a link to the old one so the comments are visible?
>> >
>> >
>> > _______________________________________________
>> > jboss-as7-dev mailing list
>> >
>> [hidden email]
>>
>> >
>> https://lists.jboss.org/mailman/listinfo/jboss-as7-dev
>>
>>
>>
>> _______________________________________________
>> jboss-as7-dev mailing list
>>
>> [hidden email]
>> https://lists.jboss.org/mailman/listinfo/jboss-as7-dev
> _______________________________________________
> jboss-as7-dev mailing list
> [hidden email]
> https://lists.jboss.org/mailman/listinfo/jboss-as7-dev


_______________________________________________
jboss-as7-dev mailing list
[hidden email]
https://lists.jboss.org/mailman/listinfo/jboss-as7-dev