Dependency info on component upgrade pull requests

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

Dependency info on component upgrade pull requests

Brian Stansberry
I'd like to see some info on WildFly and WildFly Core pull requests that upgrade components where the submitter *is not* the "exclusive owner" of the lib being upgraded.

An "owner" of a component is the person recorded in WFLY or WFCORE as the lead of the JIRA component that tracks issues related to the functionality the lib's used for. An owner is "exclusive" if his or her JIRA component is the only relevant one.

The info I'd like:

1) Information showing the the modules that depend on the updated lib. This is quite easy to get once you know the name of the module that includes the lib (and if you don't know that you probably shouldn't be submitting the PR.)

$ git grep javax.json.api | grep module.xml

core-feature-pack/src/main/resources/modules/system/layers/base/javax/json/api/main/module.xml:<module xmlns="urn:jboss:module:1.5" name="javax.json.api">

core-feature-pack/src/main/resources/modules/system/layers/base/org/wildfly/security/elytron-private/main/module.xml:        <module name="javax.json.api"/>


Since this lib is in core, it may have uses in full so include that too:

$ git grep javax.json.api | grep module.xml

feature-pack/src/main/resources/modules/system/layers/base/javaee/api/main/module.xml:        <module name="javax.json.api" export="true"/>

feature-pack/src/main/resources/modules/system/layers/base/org/apache/activemq/artemis/main/module.xml:        <module name="javax.json.api"/>

feature-pack/src/main/resources/modules/system/layers/base/org/jboss/resteasy/resteasy-json-p-provider/main/module.xml:        <module name="javax.json.api"/>


2) An @ mention of the owners of the component identified above so they are aware of and can approve the change. If you don't know who these people are, skip this. But if you're someone who really should know this stuff, please learn it and include it. Owners, please respond to these mentions.


I don't think asking for this stuff from the exclusive owner of a lib makes sense; they should know what they are doing and the cost of added paperwork exceeds any likely benefit.


Thanks,

Brian


_______________________________________________
wildfly-dev mailing list
[hidden email]
https://lists.jboss.org/mailman/listinfo/wildfly-dev