How to verify a patches for non-public AS

classic Classic list List threaded Threaded
32 messages Options
12
Reply | Threaded
Open this post in threaded view
|

How to verify a patches for non-public AS

Thomas Diesler
Folks,

when I resolve a bug for EAP, how can the reporter verify that the patch is working so that the issue can be closed?

cheers
--thomas
xxxxxxxxxxxxxxxxxxxxxxxxxxxx
Thomas Diesler
JBoss OSGi Lead
JBoss, a division of Red Hat
xxxxxxxxxxxxxxxxxxxxxxxxxxxx




_______________________________________________
jboss-as7-dev mailing list
[hidden email]
https://lists.jboss.org/mailman/listinfo/jboss-as7-dev
Reply | Threaded
Open this post in threaded view
|

Re: How to verify a patches for non-public AS

Darran Lofthouse
Thomas - to get it into EAP it must have also had a BZ which means it
would be verified by QE.

Regards,
Darran Lofthouse.


On 17/04/13 09:12, Thomas Diesler wrote:

> Folks,
>
> when I resolve a bug for EAP, how can the reporter verify that the patch is working so that the issue can be closed?
>
> cheers
> --thomas
> xxxxxxxxxxxxxxxxxxxxxxxxxxxx
> Thomas Diesler
> JBoss OSGi Lead
> JBoss, a division of Red Hat
> xxxxxxxxxxxxxxxxxxxxxxxxxxxx
>
>
>
>
> _______________________________________________
> jboss-as7-dev mailing list
> [hidden email]
> https://lists.jboss.org/mailman/listinfo/jboss-as7-dev
>
_______________________________________________
jboss-as7-dev mailing list
[hidden email]
https://lists.jboss.org/mailman/listinfo/jboss-as7-dev
Reply | Threaded
Open this post in threaded view
|

Re: How to verify a patches for non-public AS

Thomas Diesler
Hi Darran,

this does not work. There is no living soul in QA that could verify my patch and guarantee that it works for the reporter. For good reason, we distinguish between Resolved/Closed - only the reporter of an issue can make the transition from Resolved to Closed.

I'd say this process is broken.

I suggest we do all work in jboss-as until an issue is not only Resolved but also Closed. Closed issues can be picked up by QA and the associated commits cherry-picked and whatever other voodoo they do in their non-public systems.

As it stands now the reporter has to wait until the next EAP release before he can know whether his issue is truly fixed. That is obviously broken, isn't it?

cheers
--thomas

On Apr 17, 2013, at 10:20 AM, Darran Lofthouse <[hidden email]> wrote:

> Thomas - to get it into EAP it must have also had a BZ which means it
> would be verified by QE.
>
> Regards,
> Darran Lofthouse.
>
>
> On 17/04/13 09:12, Thomas Diesler wrote:
>> Folks,
>>
>> when I resolve a bug for EAP, how can the reporter verify that the patch is working so that the issue can be closed?
>>
>> cheers
>> --thomas
>> xxxxxxxxxxxxxxxxxxxxxxxxxxxx
>> Thomas Diesler
>> JBoss OSGi Lead
>> JBoss, a division of Red Hat
>> xxxxxxxxxxxxxxxxxxxxxxxxxxxx
>>
>>
>>
>>
>> _______________________________________________
>> jboss-as7-dev mailing list
>> [hidden email]
>> https://lists.jboss.org/mailman/listinfo/jboss-as7-dev
>>
> _______________________________________________
> jboss-as7-dev mailing list
> [hidden email]
> https://lists.jboss.org/mailman/listinfo/jboss-as7-dev

xxxxxxxxxxxxxxxxxxxxxxxxxxxx
Thomas Diesler
JBoss OSGi Lead
JBoss, a division of Red Hat
xxxxxxxxxxxxxxxxxxxxxxxxxxxx




_______________________________________________
jboss-as7-dev mailing list
[hidden email]
https://lists.jboss.org/mailman/listinfo/jboss-as7-dev
Reply | Threaded
Open this post in threaded view
|

Re: How to verify a patches for non-public AS

Darran Lofthouse
All issues should be going upstream first anyway into what is currently
marked as AS8 if that is what you mean?


On 17/04/13 11:16, Thomas Diesler wrote:

> Hi Darran,
>
> this does not work. There is no living soul in QA that could verify my patch and guarantee that it works for the reporter. For good reason, we distinguish between Resolved/Closed - only the reporter of an issue can make the transition from Resolved to Closed.
>
> I'd say this process is broken.
>
> I suggest we do all work in jboss-as until an issue is not only Resolved but also Closed. Closed issues can be picked up by QA and the associated commits cherry-picked and whatever other voodoo they do in their non-public systems.
>
> As it stands now the reporter has to wait until the next EAP release before he can know whether his issue is truly fixed. That is obviously broken, isn't it?
>
> cheers
> --thomas
>
> On Apr 17, 2013, at 10:20 AM, Darran Lofthouse <[hidden email]> wrote:
>
>> Thomas - to get it into EAP it must have also had a BZ which means it
>> would be verified by QE.
>>
>> Regards,
>> Darran Lofthouse.
>>
>>
>> On 17/04/13 09:12, Thomas Diesler wrote:
>>> Folks,
>>>
>>> when I resolve a bug for EAP, how can the reporter verify that the patch is working so that the issue can be closed?
>>>
>>> cheers
>>> --thomas
>>> xxxxxxxxxxxxxxxxxxxxxxxxxxxx
>>> Thomas Diesler
>>> JBoss OSGi Lead
>>> JBoss, a division of Red Hat
>>> xxxxxxxxxxxxxxxxxxxxxxxxxxxx
>>>
>>>
>>>
>>>
>>> _______________________________________________
>>> jboss-as7-dev mailing list
>>> [hidden email]
>>> https://lists.jboss.org/mailman/listinfo/jboss-as7-dev
>>>
>> _______________________________________________
>> jboss-as7-dev mailing list
>> [hidden email]
>> https://lists.jboss.org/mailman/listinfo/jboss-as7-dev
>
> xxxxxxxxxxxxxxxxxxxxxxxxxxxx
> Thomas Diesler
> JBoss OSGi Lead
> JBoss, a division of Red Hat
> xxxxxxxxxxxxxxxxxxxxxxxxxxxx
>
>
>
_______________________________________________
jboss-as7-dev mailing list
[hidden email]
https://lists.jboss.org/mailman/listinfo/jboss-as7-dev
Reply | Threaded
Open this post in threaded view
|

Re: How to verify a patches for non-public AS

Thomas Diesler
The upstream process is fine.

This thread is about bugs reported against EAP 6.1.0.Alpha1

On Apr 17, 2013, at 12:47 PM, Darran Lofthouse <[hidden email]> wrote:

All issues should be going upstream first anyway into what is currently marked as AS8 if that is what you mean?


On 17/04/13 11:16, Thomas Diesler wrote:
Hi Darran,

this does not work. There is no living soul in QA that could verify my patch and guarantee that it works for the reporter. For good reason, we distinguish between Resolved/Closed - only the reporter of an issue can make the transition from Resolved to Closed.

I'd say this process is broken.

I suggest we do all work in jboss-as until an issue is not only Resolved but also Closed. Closed issues can be picked up by QA and the associated commits cherry-picked and whatever other voodoo they do in their non-public systems.

As it stands now the reporter has to wait until the next EAP release before he can know whether his issue is truly fixed. That is obviously broken, isn't it?

cheers
--thomas

On Apr 17, 2013, at 10:20 AM, Darran Lofthouse <[hidden email]> wrote:

Thomas - to get it into EAP it must have also had a BZ which means it
would be verified by QE.

Regards,
Darran Lofthouse.


On 17/04/13 09:12, Thomas Diesler wrote:
Folks,

when I resolve a bug for EAP, how can the reporter verify that the patch is working so that the issue can be closed?

cheers
--thomas
xxxxxxxxxxxxxxxxxxxxxxxxxxxx
Thomas Diesler
JBoss OSGi Lead
JBoss, a division of Red Hat
xxxxxxxxxxxxxxxxxxxxxxxxxxxx




_______________________________________________
jboss-as7-dev mailing list
[hidden email]
https://lists.jboss.org/mailman/listinfo/jboss-as7-dev

_______________________________________________
jboss-as7-dev mailing list
[hidden email]
https://lists.jboss.org/mailman/listinfo/jboss-as7-dev

xxxxxxxxxxxxxxxxxxxxxxxxxxxx
Thomas Diesler
JBoss OSGi Lead
JBoss, a division of Red Hat
xxxxxxxxxxxxxxxxxxxxxxxxxxxx




xxxxxxxxxxxxxxxxxxxxxxxxxxxx
Thomas Diesler
JBoss OSGi Lead
JBoss, a division of Red Hat
xxxxxxxxxxxxxxxxxxxxxxxxxxxx 




_______________________________________________
jboss-as7-dev mailing list
[hidden email]
https://lists.jboss.org/mailman/listinfo/jboss-as7-dev
Reply | Threaded
Open this post in threaded view
|

Re: How to verify a patches for non-public AS

Heiko Braun
I think what Darran is trying to say, is that any EAP issue needs to have an upstream issue first anyway.
That mean you can verify it against the community builds.

On Apr 17, 2013, at 12:55 PM, Thomas Diesler <[hidden email]> wrote:

The upstream process is fine.

This thread is about bugs reported against EAP 6.1.0.Alpha1

On Apr 17, 2013, at 12:47 PM, Darran Lofthouse <[hidden email]> wrote:

All issues should be going upstream first anyway into what is currently marked as AS8 if that is what you mean?


On 17/04/13 11:16, Thomas Diesler wrote:
Hi Darran,

this does not work. There is no living soul in QA that could verify my patch and guarantee that it works for the reporter. For good reason, we distinguish between Resolved/Closed - only the reporter of an issue can make the transition from Resolved to Closed.

I'd say this process is broken.

I suggest we do all work in jboss-as until an issue is not only Resolved but also Closed. Closed issues can be picked up by QA and the associated commits cherry-picked and whatever other voodoo they do in their non-public systems.

As it stands now the reporter has to wait until the next EAP release before he can know whether his issue is truly fixed. That is obviously broken, isn't it?

cheers
--thomas

On Apr 17, 2013, at 10:20 AM, Darran Lofthouse <[hidden email]> wrote:

Thomas - to get it into EAP it must have also had a BZ which means it
would be verified by QE.

Regards,
Darran Lofthouse.


On 17/04/13 09:12, Thomas Diesler wrote:
Folks,

when I resolve a bug for EAP, how can the reporter verify that the patch is working so that the issue can be closed?

cheers
--thomas
xxxxxxxxxxxxxxxxxxxxxxxxxxxx
Thomas Diesler
JBoss OSGi Lead
JBoss, a division of Red Hat
xxxxxxxxxxxxxxxxxxxxxxxxxxxx




_______________________________________________
jboss-as7-dev mailing list
[hidden email]
https://lists.jboss.org/mailman/listinfo/jboss-as7-dev

_______________________________________________
jboss-as7-dev mailing list
[hidden email]
https://lists.jboss.org/mailman/listinfo/jboss-as7-dev

xxxxxxxxxxxxxxxxxxxxxxxxxxxx
Thomas Diesler
JBoss OSGi Lead
JBoss, a division of Red Hat
xxxxxxxxxxxxxxxxxxxxxxxxxxxx




xxxxxxxxxxxxxxxxxxxxxxxxxxxx
Thomas Diesler
JBoss OSGi Lead
JBoss, a division of Red Hat
xxxxxxxxxxxxxxxxxxxxxxxxxxxx 



_______________________________________________
jboss-as7-dev mailing list
[hidden email]
https://lists.jboss.org/mailman/listinfo/jboss-as7-dev


_______________________________________________
jboss-as7-dev mailing list
[hidden email]
https://lists.jboss.org/mailman/listinfo/jboss-as7-dev
Reply | Threaded
Open this post in threaded view
|

Re: How to verify a patches for non-public AS

Thomas Diesler
AFAIU, the source tree is jboss-eap, which is not accessible for the reporter. 
So the reporter cannot make the transition from Resolved to Closed.

All would be good if the reporter can verify the patch before it goes in the next EAP release, can he?

On Apr 17, 2013, at 12:57 PM, Heiko Braun <[hidden email]> wrote:

I think what Darran is trying to say, is that any EAP issue needs to have an upstream issue first anyway.
That mean you can verify it against the community builds.

On Apr 17, 2013, at 12:55 PM, Thomas Diesler <[hidden email]> wrote:

The upstream process is fine.

This thread is about bugs reported against EAP 6.1.0.Alpha1

On Apr 17, 2013, at 12:47 PM, Darran Lofthouse <[hidden email]> wrote:

All issues should be going upstream first anyway into what is currently marked as AS8 if that is what you mean?


On 17/04/13 11:16, Thomas Diesler wrote:
Hi Darran,

this does not work. There is no living soul in QA that could verify my patch and guarantee that it works for the reporter. For good reason, we distinguish between Resolved/Closed - only the reporter of an issue can make the transition from Resolved to Closed.

I'd say this process is broken.

I suggest we do all work in jboss-as until an issue is not only Resolved but also Closed. Closed issues can be picked up by QA and the associated commits cherry-picked and whatever other voodoo they do in their non-public systems.

As it stands now the reporter has to wait until the next EAP release before he can know whether his issue is truly fixed. That is obviously broken, isn't it?

cheers
--thomas

On Apr 17, 2013, at 10:20 AM, Darran Lofthouse <[hidden email]> wrote:

Thomas - to get it into EAP it must have also had a BZ which means it
would be verified by QE.

Regards,
Darran Lofthouse.


On 17/04/13 09:12, Thomas Diesler wrote:
Folks,

when I resolve a bug for EAP, how can the reporter verify that the patch is working so that the issue can be closed?

cheers
--thomas
xxxxxxxxxxxxxxxxxxxxxxxxxxxx
Thomas Diesler
JBoss OSGi Lead
JBoss, a division of Red Hat
xxxxxxxxxxxxxxxxxxxxxxxxxxxx




_______________________________________________
jboss-as7-dev mailing list
[hidden email]
https://lists.jboss.org/mailman/listinfo/jboss-as7-dev

_______________________________________________
jboss-as7-dev mailing list
[hidden email]
https://lists.jboss.org/mailman/listinfo/jboss-as7-dev

xxxxxxxxxxxxxxxxxxxxxxxxxxxx
Thomas Diesler
JBoss OSGi Lead
JBoss, a division of Red Hat
xxxxxxxxxxxxxxxxxxxxxxxxxxxx




xxxxxxxxxxxxxxxxxxxxxxxxxxxx
Thomas Diesler
JBoss OSGi Lead
JBoss, a division of Red Hat
xxxxxxxxxxxxxxxxxxxxxxxxxxxx 



_______________________________________________
jboss-as7-dev mailing list
[hidden email]
https://lists.jboss.org/mailman/listinfo/jboss-as7-dev


xxxxxxxxxxxxxxxxxxxxxxxxxxxx
Thomas Diesler
JBoss OSGi Lead
JBoss, a division of Red Hat
xxxxxxxxxxxxxxxxxxxxxxxxxxxx 




_______________________________________________
jboss-as7-dev mailing list
[hidden email]
https://lists.jboss.org/mailman/listinfo/jboss-as7-dev
Reply | Threaded
Open this post in threaded view
|

Re: How to verify a patches for non-public AS

Heiko Braun


If the patch needs to be upstream first, the upstream build can be used to verified it, no?



On Apr 17, 2013, at 1:02 PM, Thomas Diesler <[hidden email]> wrote:

All would be good if the reporter can verify the patch before it goes in the next EAP release, can he?


_______________________________________________
jboss-as7-dev mailing list
[hidden email]
https://lists.jboss.org/mailman/listinfo/jboss-as7-dev
Reply | Threaded
Open this post in threaded view
|

Re: How to verify a patches for non-public AS

Thomas Diesler
… and where is upstream for EAP-6.x ?

I think it is jboss-eap/6.x, and not jboss-as/7.1

On Apr 17, 2013, at 1:04 PM, Heiko Braun <[hidden email]> wrote:



If the patch needs to be upstream first, the upstream build can be used to verified it, no?



On Apr 17, 2013, at 1:02 PM, Thomas Diesler <[hidden email]> wrote:

All would be good if the reporter can verify the patch before it goes in the next EAP release, can he?


xxxxxxxxxxxxxxxxxxxxxxxxxxxx
Thomas Diesler
JBoss OSGi Lead
JBoss, a division of Red Hat
xxxxxxxxxxxxxxxxxxxxxxxxxxxx 




_______________________________________________
jboss-as7-dev mailing list
[hidden email]
https://lists.jboss.org/mailman/listinfo/jboss-as7-dev
Reply | Threaded
Open this post in threaded view
|

Re: How to verify a patches for non-public AS

Darran Lofthouse
The overall upstream is the master branch of jboss-as

On 17/04/13 12:09, Thomas Diesler wrote:

> … and where is upstream for EAP-6.x ?
>
> I think it is jboss-eap/6.x <https://github.com/jbossas/jboss-eap>, and
> not jboss-as/7.1 <https://github.com/jbossas/jboss-as/tree/7.1>
>
> On Apr 17, 2013, at 1:04 PM, Heiko Braun <[hidden email]
> <mailto:[hidden email]>> wrote:
>
>>
>>
>> If the patch needs to be upstream first, the upstream build can be
>> used to verified it, no?
>>
>>
>>
>> On Apr 17, 2013, at 1:02 PM, Thomas Diesler <[hidden email]
>> <mailto:[hidden email]>> wrote:
>>
>>> All would be good if the reporter can verify the patch before it goes
>>> in the next EAP release, can he?
>>
>
> xxxxxxxxxxxxxxxxxxxxxxxxxxxx
> Thomas Diesler
> JBoss OSGi Lead
> JBoss, a division of Red Hat
> xxxxxxxxxxxxxxxxxxxxxxxxxxxx
>
>
>
>
_______________________________________________
jboss-as7-dev mailing list
[hidden email]
https://lists.jboss.org/mailman/listinfo/jboss-as7-dev
Reply | Threaded
Open this post in threaded view
|

Re: How to verify a patches for non-public AS

Heiko Braun



right, that's what i thought.

On Apr 17, 2013, at 1:23 PM, Darran Lofthouse <[hidden email]> wrote:

The overall upstream is the master branch of jboss-as


_______________________________________________
jboss-as7-dev mailing list
[hidden email]
https://lists.jboss.org/mailman/listinfo/jboss-as7-dev
Reply | Threaded
Open this post in threaded view
|

Re: How to verify a patches for non-public AS

Thomas Diesler
In reply to this post by Darran Lofthouse
Yes of course. I'm talking about a patch that applies to the 7.1 code base only.
A commit that cannot be made in jboss-as, but only in jboos-eap.
A fix to the R4V42 OSGi Framework.
In AS8 we have the R5 Framework.  
 
On Apr 17, 2013, at 1:23 PM, Darran Lofthouse <[hidden email]> wrote:

> The overall upstream is the master branch of jboss-as
>
> On 17/04/13 12:09, Thomas Diesler wrote:
>> … and where is upstream for EAP-6.x ?
>>
>> I think it is jboss-eap/6.x <https://github.com/jbossas/jboss-eap>, and
>> not jboss-as/7.1 <https://github.com/jbossas/jboss-as/tree/7.1>
>>
>> On Apr 17, 2013, at 1:04 PM, Heiko Braun <[hidden email]
>> <mailto:[hidden email]>> wrote:
>>
>>>
>>>
>>> If the patch needs to be upstream first, the upstream build can be
>>> used to verified it, no?
>>>
>>>
>>>
>>> On Apr 17, 2013, at 1:02 PM, Thomas Diesler <[hidden email]
>>> <mailto:[hidden email]>> wrote:
>>>
>>>> All would be good if the reporter can verify the patch before it goes
>>>> in the next EAP release, can he?
>>>
>>
>> xxxxxxxxxxxxxxxxxxxxxxxxxxxx
>> Thomas Diesler
>> JBoss OSGi Lead
>> JBoss, a division of Red Hat
>> xxxxxxxxxxxxxxxxxxxxxxxxxxxx
>>
>>
>>
>>

xxxxxxxxxxxxxxxxxxxxxxxxxxxx
Thomas Diesler
JBoss OSGi Lead
JBoss, a division of Red Hat
xxxxxxxxxxxxxxxxxxxxxxxxxxxx




_______________________________________________
jboss-as7-dev mailing list
[hidden email]
https://lists.jboss.org/mailman/listinfo/jboss-as7-dev
Reply | Threaded
Open this post in threaded view
|

Re: How to verify a patches for non-public AS

Fernando Nasser
In reply to this post by Thomas Diesler
Right, jboss-eap/6.x   is  the AS 7.2.x series that only exists for EAP 6 purposes.

The jboss-as/7.1 died at 7.1.3 by EAP 6.0.1 time, and the jboss-as/master moved to AS8 and it is already considerably different.



>
> … and where is upstream for EAP-6.x ?
>
>
> I think it is jboss-eap/6.x , and not jboss-as/7.1
>
>
>
>
> On Apr 17, 2013, at 1:04 PM, Heiko Braun < [hidden email] > wrote:
>
>
>
>
>
>
>
>
> If the patch needs to be upstream first, the upstream build can be
> used to verified it, no?
>
>
>
>
>
>
> On Apr 17, 2013, at 1:02 PM, Thomas Diesler <
> [hidden email] > wrote:
>
>
> All would be good if the reporter can verify the patch before it goes
> in the next EAP release, can he?
>
>
>
> xxxxxxxxxxxxxxxxxxxxxxxxxxxx
> Thomas Diesler
> JBoss OSGi Lead
> JBoss, a division of Red Hat
> xxxxxxxxxxxxxxxxxxxxxxxxxxxx
>
>
>
>
> _______________________________________________
> jboss-as7-dev mailing list
> [hidden email]
> https://lists.jboss.org/mailman/listinfo/jboss-as7-dev

_______________________________________________
jboss-as7-dev mailing list
[hidden email]
https://lists.jboss.org/mailman/listinfo/jboss-as7-dev
Reply | Threaded
Open this post in threaded view
|

Re: How to verify a patches for non-public AS

Thomas Diesler
Thank for confirming this Fernando. Earlier in the thread I said 

There is no living soul in QA that could verify my patch and guarantee that it works for the reporter. For good reason, we distinguish between Resolved/Closed - only the reporter of an issue can make the transition from Resolved to Closed. 

I'd say this process is broken.

I suggest we do all work in jboss-as until an issue is not only Resolved but also Closed. Closed issues can be picked up by QA and the associated commits cherry-picked and whatever other voodoo they do in their non-public systems. 

As it stands now the reporter has to wait until the next EAP release before he can know whether his issue is truly fixed. That is obviously broken, isn't it?

What would you say about that?

cheers
--thomas
 
On Apr 17, 2013, at 3:10 PM, Fernando Nasser <[hidden email]> wrote:

Right, jboss-eap/6.x   is  the AS 7.2.x series that only exists for EAP 6 purposes.

The jboss-as/7.1 died at 7.1.3 by EAP 6.0.1 time, and the jboss-as/master moved to AS8 and it is already considerably different.




… and where is upstream for EAP-6.x ?


I think it is jboss-eap/6.x , and not jboss-as/7.1




On Apr 17, 2013, at 1:04 PM, Heiko Braun < [hidden email] > wrote:








If the patch needs to be upstream first, the upstream build can be
used to verified it, no?






On Apr 17, 2013, at 1:02 PM, Thomas Diesler <
[hidden email] > wrote:


All would be good if the reporter can verify the patch before it goes
in the next EAP release, can he?



xxxxxxxxxxxxxxxxxxxxxxxxxxxx
Thomas Diesler
JBoss OSGi Lead
JBoss, a division of Red Hat
xxxxxxxxxxxxxxxxxxxxxxxxxxxx




_______________________________________________
jboss-as7-dev mailing list
[hidden email]
https://lists.jboss.org/mailman/listinfo/jboss-as7-dev

xxxxxxxxxxxxxxxxxxxxxxxxxxxx
Thomas Diesler
JBoss OSGi Lead
JBoss, a division of Red Hat
xxxxxxxxxxxxxxxxxxxxxxxxxxxx 




_______________________________________________
jboss-as7-dev mailing list
[hidden email]
https://lists.jboss.org/mailman/listinfo/jboss-as7-dev
Reply | Threaded
Open this post in threaded view
|

Re: How to verify a patches for non-public AS

Fernando Lozano
In reply to this post by Thomas Diesler
Hi there,

The URL https://github.com/jbossas/jboss-eap returns 404. I can find only as tags and releases, no eap.

So the only way to get sources for EAP is waiting for Red Hat to release the zip file at

ftp://ftp.redhat.com/redhat/jbeap/

And customers wishing to try a patch to confirm an issue is solved have no way to do that, unless the developer sends them the patch file by other means (e-mail) and the patch file does not depends on any other change made to the trunk since the latest release.

Am I right?


[]s, Fernando Lozano


… and where is upstream for EAP-6.x ?

I think it is jboss-eap/6.x, and not jboss-as/7.1

On Apr 17, 2013, at 1:04 PM, Heiko Braun <[hidden email]> wrote:



If the patch needs to be upstream first, the upstream build can be used to verified it, no?



On Apr 17, 2013, at 1:02 PM, Thomas Diesler <[hidden email]> wrote:

All would be good if the reporter can verify the patch before it goes in the next EAP release, can he?


xxxxxxxxxxxxxxxxxxxxxxxxxxxx
Thomas Diesler
JBoss OSGi Lead
JBoss, a division of Red Hat
xxxxxxxxxxxxxxxxxxxxxxxxxxxx 





_______________________________________________
jboss-as7-dev mailing list
[hidden email]
https://lists.jboss.org/mailman/listinfo/jboss-as7-dev


_______________________________________________
jboss-as7-dev mailing list
[hidden email]
https://lists.jboss.org/mailman/listinfo/jboss-as7-dev
Reply | Threaded
Open this post in threaded view
|

Re: How to verify a patches for non-public AS

Dimitris Andreadis
In reply to this post by Thomas Diesler
At least the next EAP 6.1.0.Beta shouldn't be long, as long as it includes the fix.

On 17/04/2013 12:55, Thomas Diesler wrote:

> The upstream process is fine.
>
> This thread is about bugs <https://issues.jboss.org/browse/JBEAP-8> reported against EAP
> 6.1.0.Alpha1 <https://issues.jboss.org/browse/JBEAP/fixforversion/12321330>
>
> On Apr 17, 2013, at 12:47 PM, Darran Lofthouse <[hidden email]
> <mailto:[hidden email]>> wrote:
>
>> All issues should be going upstream first anyway into what is currently marked as AS8 if
>> that is what you mean?
>>
>>
>> On 17/04/13 11:16, Thomas Diesler wrote:
>>> Hi Darran,
>>>
>>> this does not work. There is no living soul in QA that could verify my patch and
>>> guarantee that it works for the reporter. For good reason, we distinguish between
>>> Resolved/Closed - only the reporter of an issue can make the transition from Resolved to
>>> Closed.
>>>
>>> I'd say this process is broken.
>>>
>>> I suggest we do all work in jboss-as until an issue is not only Resolved but also Closed.
>>> Closed issues can be picked up by QA and the associated commits cherry-picked and
>>> whatever other voodoo they do in their non-public systems.
>>>
>>> As it stands now the reporter has to wait until the next EAP release before he can know
>>> whether his issue is truly fixed. That is obviously broken, isn't it?
>>>
>>> cheers
>>> --thomas
>>>
>>> On Apr 17, 2013, at 10:20 AM, Darran Lofthouse <[hidden email]
>>> <mailto:[hidden email]>> wrote:
>>>
>>>> Thomas - to get it into EAP it must have also had a BZ which means it
>>>> would be verified by QE.
>>>>
>>>> Regards,
>>>> Darran Lofthouse.
>>>>
>>>>
>>>> On 17/04/13 09:12, Thomas Diesler wrote:
>>>>> Folks,
>>>>>
>>>>> when I resolve a bug for EAP, how can the reporter verify that the patch is working so
>>>>> that the issue can be closed?
>>>>>
>>>>> cheers
>>>>> --thomas
>>>>> xxxxxxxxxxxxxxxxxxxxxxxxxxxx
>>>>> Thomas Diesler
>>>>> JBoss OSGi Lead
>>>>> JBoss, a division of Red Hat
>>>>> xxxxxxxxxxxxxxxxxxxxxxxxxxxx
>>>>>
>>>>>
>>>>>
>>>>>
>>>>> _______________________________________________
>>>>> jboss-as7-dev mailing list
>>>>> [hidden email] <mailto:[hidden email]>
>>>>> https://lists.jboss.org/mailman/listinfo/jboss-as7-dev
>>>>>
>>>> _______________________________________________
>>>> jboss-as7-dev mailing list
>>>> [hidden email] <mailto:[hidden email]>
>>>> https://lists.jboss.org/mailman/listinfo/jboss-as7-dev
>>>
>>> xxxxxxxxxxxxxxxxxxxxxxxxxxxx
>>> Thomas Diesler
>>> JBoss OSGi Lead
>>> JBoss, a division of Red Hat
>>> xxxxxxxxxxxxxxxxxxxxxxxxxxxx
>>>
>>>
>>>
>
> xxxxxxxxxxxxxxxxxxxxxxxxxxxx
> Thomas Diesler
> JBoss OSGi Lead
> JBoss, a division of Red Hat
> xxxxxxxxxxxxxxxxxxxxxxxxxxxx
>
>
>
>
>
>
> _______________________________________________
> jboss-as7-dev mailing list
> [hidden email]
> https://lists.jboss.org/mailman/listinfo/jboss-as7-dev
>

--
xxxxxxxxxxxxxxxxxxxxxxxxxxxx
Dimitris Andreadis
Software Engineering Manager
JBoss Application Server
by Red Hat
xxxxxxxxxxxxxxxxxxxxxxxxxxxx

http://dandreadis.blogspot.com/
_______________________________________________
jboss-as7-dev mailing list
[hidden email]
https://lists.jboss.org/mailman/listinfo/jboss-as7-dev
Reply | Threaded
Open this post in threaded view
|

Re: How to verify a patches for non-public AS

Brian Stansberry
In reply to this post by Thomas Diesler
Any fix in EAP has a bugzilla behind it, and QE verifies all bugzillas
before they are closed.

The fix should be fixed in the upstream AS7 project at the same time or
earlier, so the reporter can verify there. Granted, there can be
relevant differences between upstream and EAP. For the reporter to
verify against EAP itself they'll need to wait for the EAP beta or
whatever that contains the fix.

On 4/17/13 3:07 AM, Thomas Diesler wrote:
> Folks,
>
> when I resolve a bug for non-public AS, how can the reporter verify that the patch is working so that the issue can be closed?
>
> cheers
> --thomas
>


--
Brian Stansberry
Principal Software Engineer
JBoss by Red Hat
_______________________________________________
jboss-as7-dev mailing list
[hidden email]
https://lists.jboss.org/mailman/listinfo/jboss-as7-dev
Reply | Threaded
Open this post in threaded view
|

Re: How to verify a patches for non-public AS

Brian Stansberry
Hah, this message was in my mailbox twice and I responded before seeing
the other version with the long thread attached.

On 4/17/13 9:22 AM, Brian Stansberry wrote:

> Any fix in EAP has a bugzilla behind it, and QE verifies all bugzillas
> before they are closed.
>
> The fix should be fixed in the upstream AS7 project at the same time or
> earlier, so the reporter can verify there. Granted, there can be
> relevant differences between upstream and EAP. For the reporter to
> verify against EAP itself they'll need to wait for the EAP beta or
> whatever that contains the fix.
>
> On 4/17/13 3:07 AM, Thomas Diesler wrote:
>> Folks,
>>
>> when I resolve a bug for non-public AS, how can the reporter verify that the patch is working so that the issue can be closed?
>>
>> cheers
>> --thomas
>>
>
>


--
Brian Stansberry
Principal Software Engineer
JBoss by Red Hat
_______________________________________________
jboss-as7-dev mailing list
[hidden email]
https://lists.jboss.org/mailman/listinfo/jboss-as7-dev
Reply | Threaded
Open this post in threaded view
|

Re: How to verify a patches for non-public AS

Thomas Diesler
In reply to this post by Fernando Lozano

On Apr 17, 2013, at 4:19 PM, Fernando Lozano <[hidden email]> wrote:

Hi there,

The URL https://github.com/jbossas/jboss-eap returns 404. I can find only as tags and releases, no eap.

So the only way to get sources for EAP is waiting for Red Hat to release the zip file at

ftp://ftp.redhat.com/redhat/jbeap/

And customers wishing to try a patch to confirm an issue is solved have no way to do that, unless the developer sends them the patch file by other means (e-mail) and the patch file does not depends on any other change made to the trunk since the latest release.

Am I right?

Yes, thats it. I provide a patch to the best of my knowledge and there is no way to verify that patch until it is part of a release. The reporter can verify the release and only then report back that the patch is not valid. 

Unfortunately, I don't have a good answer on how to fix this other than "make jboss-eap public". Then again, I don't really understand why it is so secret what we do there if we release eap+sources every couple of months anyway.



[]s, Fernando Lozano


… and where is upstream for EAP-6.x ?

I think it is jboss-eap/6.x, and not jboss-as/7.1

On Apr 17, 2013, at 1:04 PM, Heiko Braun <[hidden email]> wrote:



If the patch needs to be upstream first, the upstream build can be used to verified it, no?



On Apr 17, 2013, at 1:02 PM, Thomas Diesler <[hidden email]> wrote:

All would be good if the reporter can verify the patch before it goes in the next EAP release, can he?


xxxxxxxxxxxxxxxxxxxxxxxxxxxx
Thomas Diesler
JBoss OSGi Lead
JBoss, a division of Red Hat
xxxxxxxxxxxxxxxxxxxxxxxxxxxx 





_______________________________________________
jboss-as7-dev mailing list
[hidden email]
https://lists.jboss.org/mailman/listinfo/jboss-as7-dev


xxxxxxxxxxxxxxxxxxxxxxxxxxxx
Thomas Diesler
JBoss OSGi Lead
JBoss, a division of Red Hat
xxxxxxxxxxxxxxxxxxxxxxxxxxxx 




_______________________________________________
jboss-as7-dev mailing list
[hidden email]
https://lists.jboss.org/mailman/listinfo/jboss-as7-dev
Reply | Threaded
Open this post in threaded view
|

Re: How to verify a patches for non-public AS

Thomas Diesler
In reply to this post by Fernando Lozano

On Apr 17, 2013, at 4:19 PM, Fernando Lozano <[hidden email]> wrote:

Hi there,

The URL https://github.com/jbossas/jboss-eap returns 404. I can find only as tags and releases, no eap.

So the only way to get sources for EAP is waiting for Red Hat to release the zip file at

ftp://ftp.redhat.com/redhat/jbeap/

And customers wishing to try a patch to confirm an issue is solved have no way to do that, unless the developer sends them the patch file by other means (e-mail) and the patch file does not depends on any other change made to the trunk since the latest release.

Am I right?



Yes, thats it. I provide a patch to the best of my knowledge and there is no way to verify that patch until it is part of a release. The reporter can verify the release and only then report back that the patch is not valid. 

Unfortunately, I don't have a good answer on how to fix this other than "make jboss-eap public". Then again, I don't really understand why it is so secret what we do there if we release eap+sources every couple of months anyway.



[]s, Fernando Lozano


… and where is upstream for EAP-6.x ?

I think it is jboss-eap/6.x, and not jboss-as/7.1

On Apr 17, 2013, at 1:04 PM, Heiko Braun <[hidden email]> wrote:



If the patch needs to be upstream first, the upstream build can be used to verified it, no?



On Apr 17, 2013, at 1:02 PM, Thomas Diesler <[hidden email]> wrote:

All would be good if the reporter can verify the patch before it goes in the next EAP release, can he?


xxxxxxxxxxxxxxxxxxxxxxxxxxxx
Thomas Diesler
JBoss OSGi Lead
JBoss, a division of Red Hat
xxxxxxxxxxxxxxxxxxxxxxxxxxxx 





_______________________________________________
jboss-as7-dev mailing list
[hidden email]
https://lists.jboss.org/mailman/listinfo/jboss-as7-dev


       []s, Fernando Lozano


… and where is upstream for EAP-6.x ?

I think it is jboss-eap/6.x, and not jboss-as/7.1

On Apr 17, 2013, at 1:04 PM, Heiko Braun <[hidden email]> wrote:



If the patch needs to be upstream first, the upstream build can be used to verified it, no?



On Apr 17, 2013, at 1:02 PM, Thomas Diesler <[hidden email]> wrote:

All would be good if the reporter can verify the patch before it goes in the next EAP release, can he?


xxxxxxxxxxxxxxxxxxxxxxxxxxxx
Thomas Diesler
JBoss OSGi Lead
JBoss, a division of Red Hat
xxxxxxxxxxxxxxxxxxxxxxxxxxxx 





_______________________________________________
jboss-as7-dev mailing list
[hidden email]
https://lists.jboss.org/mailman/listinfo/jboss-as7-dev


xxxxxxxxxxxxxxxxxxxxxxxxxxxx
Thomas Diesler
JBoss OSGi Lead
JBoss, a division of Red Hat
xxxxxxxxxxxxxxxxxxxxxxxxxxxx 




_______________________________________________
jboss-as7-dev mailing list
[hidden email]
https://lists.jboss.org/mailman/listinfo/jboss-as7-dev
12