Move some dependencies to a new testbom in wildfly-core

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

Move some dependencies to a new testbom in wildfly-core

Lin Gao-2
Hi folks,

  WildFly-core's root pom acting as BOM and getting imported into WildFly's root pom via dependencyManagement
to be able to align the shared dependencies, it works good most of the time but has problems[1] on dependencies
which are used only for testing in wildfly-core but are used in production in WildFly full. Please refer to the
Jira issue[1] for more detail and context.

  There is a PR[2] open to address that problem by introducing a testbom which contains such dependencies. Any
module depending on such dependencies can add the testbom with an import scope.

  The PR tries to move the following dependencies from WildFly-core's root pom to the new created testbom:
  - commons-io:commons-io
  - com.fasterxml.jackson.core:jackson-databind
  - xalan:xalan

  Once the PR gets approved, it needs any project depending on wildfly-core's root pom to check, like adding
the commons-io:commons-io dependency in case of WildFly full[3].

  Does anyone see problems with such a move? Thank you !

[1] https://issues.redhat.com/browse/WFLY-14431
[2] https://github.com/wildfly/wildfly-core/pull/4572
[3] https://github.com/wildfly/wildfly/compare/master...gaol:update_test_dependencies_inherited_from_core?expand=1

Best Regards

-- 
Lin Gao
Senior Software Engineer
JBoss Sustaining Engineering Team

_______________________________________________
wildfly-dev mailing list -- [hidden email]
To unsubscribe send an email to [hidden email]
%(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s
Reply | Threaded
Open this post in threaded view
|

Re: Move some dependencies to a new testbom in wildfly-core

Brian Stansberry
Note that there's already a thread on this. This one was in list moderation and I approved it before seeing the other thread. So let's keep the discussion on the other thread.

On Tue, Apr 27, 2021 at 1:47 PM Lin Gao <[hidden email]> wrote:
Hi folks,

  WildFly-core's root pom acting as BOM and getting imported into WildFly's root pom via dependencyManagement
to be able to align the shared dependencies, it works good most of the time but has problems[1] on dependencies
which are used only for testing in wildfly-core but are used in production in WildFly full. Please refer to the
Jira issue[1] for more detail and context.

  There is a PR[2] open to address that problem by introducing a testbom which contains such dependencies. Any
module depending on such dependencies can add the testbom with an import scope.

  The PR tries to move the following dependencies from WildFly-core's root pom to the new created testbom:
  - commons-io:commons-io
  - com.fasterxml.jackson.core:jackson-databind
  - xalan:xalan

  Once the PR gets approved, it needs any project depending on wildfly-core's root pom to check, like adding
the commons-io:commons-io dependency in case of WildFly full[3].

  Does anyone see problems with such a move? Thank you !

[1] https://issues.redhat.com/browse/WFLY-14431
[2] https://github.com/wildfly/wildfly-core/pull/4572
[3] https://github.com/wildfly/wildfly/compare/master...gaol:update_test_dependencies_inherited_from_core?expand=1

Best Regards

-- 
Lin Gao
Senior Software Engineer
JBoss Sustaining Engineering Team
_______________________________________________
wildfly-dev mailing list -- [hidden email]
To unsubscribe send an email to [hidden email]
%(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s


--
Brian Stansberry
Principal Architect, Red Hat JBoss EAP
He/Him/His
If I am writing outside of normal office hours, it is my choice; you do not need to do the same

_______________________________________________
wildfly-dev mailing list -- [hidden email]
To unsubscribe send an email to [hidden email]
%(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s