Question about recently resolved branding issue

classic Classic list List threaded Threaded
9 messages Options
Reply | Threaded
Open this post in threaded view
|

Question about recently resolved branding issue

Max Rydahl Andersen
Hi,

Jira (some number I can't find right now since jira is down) about supporting branding of AS7 for EAP6, SOA-P 6 etc. got resolved with no comments/info
on *how* it was solved and how tools, JON, etc. is to react/use this.

Could anyone spill the beans on that ?

/max
http://about.me/maxandersen




_______________________________________________
jboss-as7-dev mailing list
[hidden email]
https://lists.jboss.org/mailman/listinfo/jboss-as7-dev
Reply | Threaded
Open this post in threaded view
|

Re: Question about recently resolved branding issue

Heiko Braun



I've been involved with branding in the past, but you need to be more specific in order to help.
What exactly are you looking for?

/Ike

On Jan 11, 2012, at 3:44 PM, Max Rydahl Andersen wrote:

Hi,

Jira (some number I can't find right now since jira is down) about supporting branding of AS7 for EAP6, SOA-P 6 etc. got resolved with no comments/info
on *how* it was solved and how tools, JON, etc. is to react/use this.

Could anyone spill the beans on that ?

/max
http://about.me/maxandersen




_______________________________________________
jboss-as7-dev mailing list
[hidden email]
https://lists.jboss.org/mailman/listinfo/jboss-as7-dev

--

Heiko Braun
Senior Software Engineer
JBoss by Red Hat






_______________________________________________
jboss-as7-dev mailing list
[hidden email]
https://lists.jboss.org/mailman/listinfo/jboss-as7-dev
Reply | Threaded
Open this post in threaded view
|

Re: Question about recently resolved branding issue

Max Rydahl Andersen
> I've been involved with branding in the past, but you need to be more specific in order to help.
> What exactly are you looking for?

As discussed on the jira (https://issues.jboss.org/browse/AS7-1807 now that jira is up)
I was concerned about the suggestion that stated the startup scripts had to state the used branding.
If that is the case then that creates a challenge for every tool/script that does not use the startup scripts.

And furthermore depending on how this branding is implemented this could be used to
identify what server we are actually installing from disk.  (i.e. SOA-P vs EAP etc. since I assume/hope that SOA-P main jar will still
be the same as EAP thus it will say EAP not SOA-P so something else is needed to separate these).

1) how was this in the end implemented ? Something need to change at startup?

2) can we use this branding content to somehow identify the server (type/name)

/max

>
> /Ike
>
> On Jan 11, 2012, at 3:44 PM, Max Rydahl Andersen wrote:
>
>> Hi,
>>
>> Jira (some number I can't find right now since jira is down) about supporting branding of AS7 for EAP6, SOA-P 6 etc. got resolved with no comments/info
>> on *how* it was solved and how tools, JON, etc. is to react/use this.
>>
>> Could anyone spill the beans on that ?
>>
>> /max
>> http://about.me/maxandersen
>>
>>
>>
>>
>> _______________________________________________
>> jboss-as7-dev mailing list
>> [hidden email]
>> https://lists.jboss.org/mailman/listinfo/jboss-as7-dev
>
> --
>
> Heiko Braun
> Senior Software Engineer
> JBoss by Red Hat
> http://about.me/hbraun
>
>
>
>
>

/max
http://about.me/maxandersen




_______________________________________________
jboss-as7-dev mailing list
[hidden email]
https://lists.jboss.org/mailman/listinfo/jboss-as7-dev
Reply | Threaded
Open this post in threaded view
|

Re: Question about recently resolved branding issue

Heiko Braun


I cannot speak for 1), because it covers too many areas which I have not been involved with.
But 2) can probably be retrieved through the HTTP API:


:read-attribute(name=<product-name|product-version>)


It's currently not set on master, but I would expect it to be there on a final build.

On Jan 11, 2012, at 4:24 PM, Max Rydahl Andersen wrote:

1) how was this in the end implemented ? Something need to change at startup?

2) can we use this branding content to somehow identify the server (type/name)

--

Heiko Braun
Senior Software Engineer
JBoss by Red Hat







Begin forwarded message:

From: Max Rydahl Andersen <[hidden email]>

Subject: Re: [jboss-as7-dev] Question about recently resolved branding issue

Date: January 11, 2012 4:24:17 PM GMT+01:00

To: Heiko Braun <[hidden email]>

Cc: "[hidden email] Development" <[hidden email]>


I've been involved with branding in the past, but you need to be more specific in order to help.
What exactly are you looking for?

As discussed on the jira (https://issues.jboss.org/browse/AS7-1807 now that jira is up)
I was concerned about the suggestion that stated the startup scripts had to state the used branding.
If that is the case then that creates a challenge for every tool/script that does not use the startup scripts.

And furthermore depending on how this branding is implemented this could be used to
identify what server we are actually installing from disk.  (i.e. SOA-P vs EAP etc. since I assume/hope that SOA-P main jar will still
be the same as EAP thus it will say EAP not SOA-P so something else is needed to separate these).

1) how was this in the end implemented ? Something need to change at startup?

2) can we use this branding content to somehow identify the server (type/name)

/max


/Ike

On Jan 11, 2012, at 3:44 PM, Max Rydahl Andersen wrote:

Hi,

Jira (some number I can't find right now since jira is down) about supporting branding of AS7 for EAP6, SOA-P 6 etc. got resolved with no comments/info
on *how* it was solved and how tools, JON, etc. is to react/use this.

Could anyone spill the beans on that ?

/max
http://about.me/maxandersen




_______________________________________________
jboss-as7-dev mailing list
[hidden email]
https://lists.jboss.org/mailman/listinfo/jboss-as7-dev

--

Heiko Braun
Senior Software Engineer
JBoss by Red Hat
http://about.me/hbraun






/max
http://about.me/maxandersen





Begin forwarded message:

From: Max Rydahl Andersen <[hidden email]>

Subject: Re: [jboss-as7-dev] Question about recently resolved branding issue

Date: January 11, 2012 4:24:17 PM GMT+01:00

To: Heiko Braun <[hidden email]>

Cc: "[hidden email] Development" <[hidden email]>


I've been involved with branding in the past, but you need to be more specific in order to help.
What exactly are you looking for?

As discussed on the jira (https://issues.jboss.org/browse/AS7-1807 now that jira is up)
I was concerned about the suggestion that stated the startup scripts had to state the used branding.
If that is the case then that creates a challenge for every tool/script that does not use the startup scripts.

And furthermore depending on how this branding is implemented this could be used to
identify what server we are actually installing from disk.  (i.e. SOA-P vs EAP etc. since I assume/hope that SOA-P main jar will still
be the same as EAP thus it will say EAP not SOA-P so something else is needed to separate these).

1) how was this in the end implemented ? Something need to change at startup?

2) can we use this branding content to somehow identify the server (type/name)

/max


/Ike

On Jan 11, 2012, at 3:44 PM, Max Rydahl Andersen wrote:

Hi,

Jira (some number I can't find right now since jira is down) about supporting branding of AS7 for EAP6, SOA-P 6 etc. got resolved with no comments/info
on *how* it was solved and how tools, JON, etc. is to react/use this.

Could anyone spill the beans on that ?

/max
http://about.me/maxandersen




_______________________________________________
jboss-as7-dev mailing list
[hidden email]
https://lists.jboss.org/mailman/listinfo/jboss-as7-dev

--

Heiko Braun
Senior Software Engineer
JBoss by Red Hat
http://about.me/hbraun






/max
http://about.me/maxandersen





Begin forwarded message:

From: Max Rydahl Andersen <[hidden email]>

Subject: Re: [jboss-as7-dev] Question about recently resolved branding issue

Date: January 11, 2012 4:24:17 PM GMT+01:00

To: Heiko Braun <[hidden email]>

Cc: "[hidden email] Development" <[hidden email]>


I've been involved with branding in the past, but you need to be more specific in order to help.
What exactly are you looking for?

As discussed on the jira (https://issues.jboss.org/browse/AS7-1807 now that jira is up)
I was concerned about the suggestion that stated the startup scripts had to state the used branding.
If that is the case then that creates a challenge for every tool/script that does not use the startup scripts.

And furthermore depending on how this branding is implemented this could be used to
identify what server we are actually installing from disk.  (i.e. SOA-P vs EAP etc. since I assume/hope that SOA-P main jar will still
be the same as EAP thus it will say EAP not SOA-P so something else is needed to separate these).

1) how was this in the end implemented ? Something need to change at startup?

2) can we use this branding content to somehow identify the server (type/name)

/max


/Ike

On Jan 11, 2012, at 3:44 PM, Max Rydahl Andersen wrote:

Hi,

Jira (some number I can't find right now since jira is down) about supporting branding of AS7 for EAP6, SOA-P 6 etc. got resolved with no comments/info
on *how* it was solved and how tools, JON, etc. is to react/use this.

Could anyone spill the beans on that ?

/max
http://about.me/maxandersen




_______________________________________________
jboss-as7-dev mailing list
[hidden email]
https://lists.jboss.org/mailman/listinfo/jboss-as7-dev

--

Heiko Braun
Senior Software Engineer
JBoss by Red Hat
http://about.me/hbraun






/max
http://about.me/maxandersen




_______________________________________________
jboss-as7-dev mailing list
[hidden email]
https://lists.jboss.org/mailman/listinfo/jboss-as7-dev
Reply | Threaded
Open this post in threaded view
|

Re: Question about recently resolved branding issue

Max Rydahl Andersen
> I cannot speak for 1), because it covers too many areas which I have not been involved with.

okey … I hope someone else can then :)

> But 2) can probably be retrieved through the HTTP API:
>
>
> :read-attribute(name=<product-name|product-version>)

That is too late since we need to identify this on disk, before the server is started

/max

>
>
> It's currently not set on master, but I would expect it to be there on a final build.
>
> On Jan 11, 2012, at 4:24 PM, Max Rydahl Andersen wrote:
>
>> 1) how was this in the end implemented ? Something need to change at startup?
>>
>> 2) can we use this branding content to somehow identify the server (type/name)
>
> --
>
> Heiko Braun
> Senior Software Engineer
> JBoss by Red Hat
> http://about.me/hbraun
>
>
>
>
>
>
>
> Begin forwarded message:
>
>> From: Max Rydahl Andersen <[hidden email]>
>> Subject: Re: [jboss-as7-dev] Question about recently resolved branding issue
>> Date: January 11, 2012 4:24:17 PM GMT+01:00
>> To: Heiko Braun <[hidden email]>
>> Cc: "[hidden email] Development" <[hidden email]>
>>
>>> I've been involved with branding in the past, but you need to be more specific in order to help.
>>> What exactly are you looking for?
>>
>> As discussed on the jira (https://issues.jboss.org/browse/AS7-1807 now that jira is up)
>> I was concerned about the suggestion that stated the startup scripts had to state the used branding.
>> If that is the case then that creates a challenge for every tool/script that does not use the startup scripts.
>>
>> And furthermore depending on how this branding is implemented this could be used to
>> identify what server we are actually installing from disk.  (i.e. SOA-P vs EAP etc. since I assume/hope that SOA-P main jar will still
>> be the same as EAP thus it will say EAP not SOA-P so something else is needed to separate these).
>>
>> 1) how was this in the end implemented ? Something need to change at startup?
>>
>> 2) can we use this branding content to somehow identify the server (type/name)
>>
>> /max
>>
>>>
>>> /Ike
>>>
>>> On Jan 11, 2012, at 3:44 PM, Max Rydahl Andersen wrote:
>>>
>>>> Hi,
>>>>
>>>> Jira (some number I can't find right now since jira is down) about supporting branding of AS7 for EAP6, SOA-P 6 etc. got resolved with no comments/info
>>>> on *how* it was solved and how tools, JON, etc. is to react/use this.
>>>>
>>>> Could anyone spill the beans on that ?
>>>>
>>>> /max
>>>> http://about.me/maxandersen
>>>>
>>>>
>>>>
>>>>
>>>> _______________________________________________
>>>> jboss-as7-dev mailing list
>>>> [hidden email]
>>>> https://lists.jboss.org/mailman/listinfo/jboss-as7-dev
>>>
>>> --
>>>
>>> Heiko Braun
>>> Senior Software Engineer
>>> JBoss by Red Hat
>>> http://about.me/hbraun
>>>
>>>
>>>
>>>
>>>
>>
>> /max
>> http://about.me/maxandersen
>>
>>
>>
>
>
> Begin forwarded message:
>
>> From: Max Rydahl Andersen <[hidden email]>
>> Subject: Re: [jboss-as7-dev] Question about recently resolved branding issue
>> Date: January 11, 2012 4:24:17 PM GMT+01:00
>> To: Heiko Braun <[hidden email]>
>> Cc: "[hidden email] Development" <[hidden email]>
>>
>>> I've been involved with branding in the past, but you need to be more specific in order to help.
>>> What exactly are you looking for?
>>
>> As discussed on the jira (https://issues.jboss.org/browse/AS7-1807 now that jira is up)
>> I was concerned about the suggestion that stated the startup scripts had to state the used branding.
>> If that is the case then that creates a challenge for every tool/script that does not use the startup scripts.
>>
>> And furthermore depending on how this branding is implemented this could be used to
>> identify what server we are actually installing from disk.  (i.e. SOA-P vs EAP etc. since I assume/hope that SOA-P main jar will still
>> be the same as EAP thus it will say EAP not SOA-P so something else is needed to separate these).
>>
>> 1) how was this in the end implemented ? Something need to change at startup?
>>
>> 2) can we use this branding content to somehow identify the server (type/name)
>>
>> /max
>>
>>>
>>> /Ike
>>>
>>> On Jan 11, 2012, at 3:44 PM, Max Rydahl Andersen wrote:
>>>
>>>> Hi,
>>>>
>>>> Jira (some number I can't find right now since jira is down) about supporting branding of AS7 for EAP6, SOA-P 6 etc. got resolved with no comments/info
>>>> on *how* it was solved and how tools, JON, etc. is to react/use this.
>>>>
>>>> Could anyone spill the beans on that ?
>>>>
>>>> /max
>>>> http://about.me/maxandersen
>>>>
>>>>
>>>>
>>>>
>>>> _______________________________________________
>>>> jboss-as7-dev mailing list
>>>> [hidden email]
>>>> https://lists.jboss.org/mailman/listinfo/jboss-as7-dev
>>>
>>> --
>>>
>>> Heiko Braun
>>> Senior Software Engineer
>>> JBoss by Red Hat
>>> http://about.me/hbraun
>>>
>>>
>>>
>>>
>>>
>>
>> /max
>> http://about.me/maxandersen
>>
>>
>>
>
>
> Begin forwarded message:
>
>> From: Max Rydahl Andersen <[hidden email]>
>> Subject: Re: [jboss-as7-dev] Question about recently resolved branding issue
>> Date: January 11, 2012 4:24:17 PM GMT+01:00
>> To: Heiko Braun <[hidden email]>
>> Cc: "[hidden email] Development" <[hidden email]>
>>
>>> I've been involved with branding in the past, but you need to be more specific in order to help.
>>> What exactly are you looking for?
>>
>> As discussed on the jira (https://issues.jboss.org/browse/AS7-1807 now that jira is up)
>> I was concerned about the suggestion that stated the startup scripts had to state the used branding.
>> If that is the case then that creates a challenge for every tool/script that does not use the startup scripts.
>>
>> And furthermore depending on how this branding is implemented this could be used to
>> identify what server we are actually installing from disk.  (i.e. SOA-P vs EAP etc. since I assume/hope that SOA-P main jar will still
>> be the same as EAP thus it will say EAP not SOA-P so something else is needed to separate these).
>>
>> 1) how was this in the end implemented ? Something need to change at startup?
>>
>> 2) can we use this branding content to somehow identify the server (type/name)
>>
>> /max
>>
>>>
>>> /Ike
>>>
>>> On Jan 11, 2012, at 3:44 PM, Max Rydahl Andersen wrote:
>>>
>>>> Hi,
>>>>
>>>> Jira (some number I can't find right now since jira is down) about supporting branding of AS7 for EAP6, SOA-P 6 etc. got resolved with no comments/info
>>>> on *how* it was solved and how tools, JON, etc. is to react/use this.
>>>>
>>>> Could anyone spill the beans on that ?
>>>>
>>>> /max
>>>> http://about.me/maxandersen
>>>>
>>>>
>>>>
>>>>
>>>> _______________________________________________
>>>> jboss-as7-dev mailing list
>>>> [hidden email]
>>>> https://lists.jboss.org/mailman/listinfo/jboss-as7-dev
>>>
>>> --
>>>
>>> Heiko Braun
>>> Senior Software Engineer
>>> JBoss by Red Hat
>>> http://about.me/hbraun
>>>
>>>
>>>
>>>
>>>
>>
>> /max
>> http://about.me/maxandersen
>>
>>
>>

/max
http://about.me/maxandersen




_______________________________________________
jboss-as7-dev mailing list
[hidden email]
https://lists.jboss.org/mailman/listinfo/jboss-as7-dev
Reply | Threaded
Open this post in threaded view
|

Re: Question about recently resolved branding issue

jtgreene
Administrator
In reply to this post by Max Rydahl Andersen
On 1/11/12 9:24 AM, Max Rydahl Andersen wrote:

>> I've been involved with branding in the past, but you need to be more specific in order to help.
>> What exactly are you looking for?
>
> As discussed on the jira (https://issues.jboss.org/browse/AS7-1807 now that jira is up)
> I was concerned about the suggestion that stated the startup scripts had to state the used branding.
> If that is the case then that creates a challenge for every tool/script that does not use the startup scripts.
>
> And furthermore depending on how this branding is implemented this could be used to
> identify what server we are actually installing from disk.  (i.e. SOA-P vs EAP etc. since I assume/hope that SOA-P main jar will still
> be the same as EAP thus it will say EAP not SOA-P so something else is needed to separate these).
>
> 1) how was this in the end implemented ? Something need to change at startup?

http://lists.jboss.org/pipermail/jboss-as7-dev/2012-January/004974.html

> 2) can we use this branding content to somehow identify the server (type/name)

For the product version, the following values will be undefined if its a
community release, or set to something if its a product:

:read-attribute(name=product-name)
:read-attribute(name=product-version)

The true real underlying component version (what maven calls it) is:

:read-attribute(name=release-version)
:read-attribute(name=release-codename)

These are set on both product and project. There is also no version
overlap on release-version, which is inline with wolf.

--
Jason T. Greene
JBoss AS Lead / EAP Platform Architect
JBoss, a division of Red Hat
_______________________________________________
jboss-as7-dev mailing list
[hidden email]
https://lists.jboss.org/mailman/listinfo/jboss-as7-dev
Reply | Threaded
Open this post in threaded view
|

Re: Question about recently resolved branding issue

Brian Stansberry
In reply to this post by Max Rydahl Andersen
On 1/11/12 10:12 AM, Max Rydahl Andersen wrote:
>> I cannot speak for 1), because it covers too many areas which I have not been involved with.
>
> okey … I hope someone else can then :)
>

https://github.com/jbossas/jboss-as/commit/e4a6c58306e27be51734776c9634f392b9c97b60#diff-21

^^^ is to the commit that implements this, showing the class that's at
the heart of it. The class is pretty self-explanatory. The "consoleSlot"
is used to determine what "slot" (implemented as a directory under
modules/org/jboss/as/console) holds the console implementation to use.

(I won't explain further since my knowledge of the details of this is
entirely derived from reading the above class.)

>> But 2) can probably be retrieved through the HTTP API:
>>
>>
>> :read-attribute(name=<product-name|product-version>)
>
> That is too late since we need to identify this on disk, before the server is started
>

Can tools implement the same algorithm?

> /max
>
>>
>>
>> It's currently not set on master, but I would expect it to be there on a final build.
>>

Jason can correct me, but I don't think so. AIUI these two attributes
will be undefined on a community build since a community build is not a
product.

:read-attribute(name=<release-name|release-version>)

provides the community info.

>> On Jan 11, 2012, at 4:24 PM, Max Rydahl Andersen wrote:
>>
>>> 1) how was this in the end implemented ? Something need to change at startup?
>>>
>>> 2) can we use this branding content to somehow identify the server (type/name)
>>
>> --
>>
>> Heiko Braun
>> Senior Software Engineer
>> JBoss by Red Hat
>> http://about.me/hbraun
>>
>>
>>
>>
>>
>>
>>
>> Begin forwarded message:
>>
>>> From: Max Rydahl Andersen<[hidden email]>
>>> Subject: Re: [jboss-as7-dev] Question about recently resolved branding issue
>>> Date: January 11, 2012 4:24:17 PM GMT+01:00
>>> To: Heiko Braun<[hidden email]>
>>> Cc: "[hidden email] Development"<[hidden email]>
>>>
>>>> I've been involved with branding in the past, but you need to be more specific in order to help.
>>>> What exactly are you looking for?
>>>
>>> As discussed on the jira (https://issues.jboss.org/browse/AS7-1807 now that jira is up)
>>> I was concerned about the suggestion that stated the startup scripts had to state the used branding.
>>> If that is the case then that creates a challenge for every tool/script that does not use the startup scripts.
>>>
>>> And furthermore depending on how this branding is implemented this could be used to
>>> identify what server we are actually installing from disk.  (i.e. SOA-P vs EAP etc. since I assume/hope that SOA-P main jar will still
>>> be the same as EAP thus it will say EAP not SOA-P so something else is needed to separate these).
>>>
>>> 1) how was this in the end implemented ? Something need to change at startup?
>>>
>>> 2) can we use this branding content to somehow identify the server (type/name)
>>>
>>> /max
>>>
>>>>
>>>> /Ike
>>>>
>>>> On Jan 11, 2012, at 3:44 PM, Max Rydahl Andersen wrote:
>>>>
>>>>> Hi,
>>>>>
>>>>> Jira (some number I can't find right now since jira is down) about supporting branding of AS7 for EAP6, SOA-P 6 etc. got resolved with no comments/info
>>>>> on *how* it was solved and how tools, JON, etc. is to react/use this.
>>>>>
>>>>> Could anyone spill the beans on that ?
>>>>>
>>>>> /max
>>>>> http://about.me/maxandersen
>>>>>
>>>>>
>>>>>
>>>>>
>>>>> _______________________________________________
>>>>> jboss-as7-dev mailing list
>>>>> [hidden email]
>>>>> https://lists.jboss.org/mailman/listinfo/jboss-as7-dev
>>>>
>>>> --
>>>>
>>>> Heiko Braun
>>>> Senior Software Engineer
>>>> JBoss by Red Hat
>>>> http://about.me/hbraun
>>>>
>>>>
>>>>
>>>>
>>>>
>>>
>>> /max
>>> http://about.me/maxandersen
>>>
>>>
>>>
>>
>>
>> Begin forwarded message:
>>
>>> From: Max Rydahl Andersen<[hidden email]>
>>> Subject: Re: [jboss-as7-dev] Question about recently resolved branding issue
>>> Date: January 11, 2012 4:24:17 PM GMT+01:00
>>> To: Heiko Braun<[hidden email]>
>>> Cc: "[hidden email] Development"<[hidden email]>
>>>
>>>> I've been involved with branding in the past, but you need to be more specific in order to help.
>>>> What exactly are you looking for?
>>>
>>> As discussed on the jira (https://issues.jboss.org/browse/AS7-1807 now that jira is up)
>>> I was concerned about the suggestion that stated the startup scripts had to state the used branding.
>>> If that is the case then that creates a challenge for every tool/script that does not use the startup scripts.
>>>
>>> And furthermore depending on how this branding is implemented this could be used to
>>> identify what server we are actually installing from disk.  (i.e. SOA-P vs EAP etc. since I assume/hope that SOA-P main jar will still
>>> be the same as EAP thus it will say EAP not SOA-P so something else is needed to separate these).
>>>
>>> 1) how was this in the end implemented ? Something need to change at startup?
>>>
>>> 2) can we use this branding content to somehow identify the server (type/name)
>>>
>>> /max
>>>
>>>>
>>>> /Ike
>>>>
>>>> On Jan 11, 2012, at 3:44 PM, Max Rydahl Andersen wrote:
>>>>
>>>>> Hi,
>>>>>
>>>>> Jira (some number I can't find right now since jira is down) about supporting branding of AS7 for EAP6, SOA-P 6 etc. got resolved with no comments/info
>>>>> on *how* it was solved and how tools, JON, etc. is to react/use this.
>>>>>
>>>>> Could anyone spill the beans on that ?
>>>>>
>>>>> /max
>>>>> http://about.me/maxandersen
>>>>>
>>>>>
>>>>>
>>>>>
>>>>> _______________________________________________
>>>>> jboss-as7-dev mailing list
>>>>> [hidden email]
>>>>> https://lists.jboss.org/mailman/listinfo/jboss-as7-dev
>>>>
>>>> --
>>>>
>>>> Heiko Braun
>>>> Senior Software Engineer
>>>> JBoss by Red Hat
>>>> http://about.me/hbraun
>>>>
>>>>
>>>>
>>>>
>>>>
>>>
>>> /max
>>> http://about.me/maxandersen
>>>
>>>
>>>
>>
>>
>> Begin forwarded message:
>>
>>> From: Max Rydahl Andersen<[hidden email]>
>>> Subject: Re: [jboss-as7-dev] Question about recently resolved branding issue
>>> Date: January 11, 2012 4:24:17 PM GMT+01:00
>>> To: Heiko Braun<[hidden email]>
>>> Cc: "[hidden email] Development"<[hidden email]>
>>>
>>>> I've been involved with branding in the past, but you need to be more specific in order to help.
>>>> What exactly are you looking for?
>>>
>>> As discussed on the jira (https://issues.jboss.org/browse/AS7-1807 now that jira is up)
>>> I was concerned about the suggestion that stated the startup scripts had to state the used branding.
>>> If that is the case then that creates a challenge for every tool/script that does not use the startup scripts.
>>>
>>> And furthermore depending on how this branding is implemented this could be used to
>>> identify what server we are actually installing from disk.  (i.e. SOA-P vs EAP etc. since I assume/hope that SOA-P main jar will still
>>> be the same as EAP thus it will say EAP not SOA-P so something else is needed to separate these).
>>>
>>> 1) how was this in the end implemented ? Something need to change at startup?
>>>
>>> 2) can we use this branding content to somehow identify the server (type/name)
>>>
>>> /max
>>>
>>>>
>>>> /Ike
>>>>
>>>> On Jan 11, 2012, at 3:44 PM, Max Rydahl Andersen wrote:
>>>>
>>>>> Hi,
>>>>>
>>>>> Jira (some number I can't find right now since jira is down) about supporting branding of AS7 for EAP6, SOA-P 6 etc. got resolved with no comments/info
>>>>> on *how* it was solved and how tools, JON, etc. is to react/use this.
>>>>>
>>>>> Could anyone spill the beans on that ?
>>>>>
>>>>> /max
>>>>> http://about.me/maxandersen
>>>>>
>>>>>
>>>>>
>>>>>
>>>>> _______________________________________________
>>>>> jboss-as7-dev mailing list
>>>>> [hidden email]
>>>>> https://lists.jboss.org/mailman/listinfo/jboss-as7-dev
>>>>
>>>> --
>>>>
>>>> Heiko Braun
>>>> Senior Software Engineer
>>>> JBoss by Red Hat
>>>> http://about.me/hbraun
>>>>
>>>>
>>>>
>>>>
>>>>
>>>
>>> /max
>>> http://about.me/maxandersen
>>>
>>>
>>>
>
> /max
> http://about.me/maxandersen
>
>
>
>
> _______________________________________________
> jboss-as7-dev mailing list
> [hidden email]
> https://lists.jboss.org/mailman/listinfo/jboss-as7-dev


--
Brian Stansberry
Principal Software Engineer
JBoss by Red Hat
_______________________________________________
jboss-as7-dev mailing list
[hidden email]
https://lists.jboss.org/mailman/listinfo/jboss-as7-dev
Reply | Threaded
Open this post in threaded view
|

Re: Question about recently resolved branding issue

jtgreene
Administrator
On 1/11/12 10:29 AM, Brian Stansberry wrote:

> On 1/11/12 10:12 AM, Max Rydahl Andersen wrote:
>>> I cannot speak for 1), because it covers too many areas which I have not been involved with.
>>
>> okey … I hope someone else can then :)
>>
>
> https://github.com/jbossas/jboss-as/commit/e4a6c58306e27be51734776c9634f392b9c97b60#diff-21
>
> ^^^ is to the commit that implements this, showing the class that's at
> the heart of it. The class is pretty self-explanatory. The "consoleSlot"
> is used to determine what "slot" (implemented as a directory under
> modules/org/jboss/as/console) holds the console implementation to use.
>
> (I won't explain further since my knowledge of the details of this is
> entirely derived from reading the above class.)
>
>>> But 2) can probably be retrieved through the HTTP API:
>>>
>>>
>>> :read-attribute(name=<product-name|product-version>)
>>
>> That is too late since we need to identify this on disk, before the server is started
>>
>
> Can tools implement the same algorithm?

This is what it would need to do:

1. Look for bin/product.conf
2. If found read it, format is slot=XXX (eap, soa-p, etc)
3. Look for a MANIFEST.MF file in one of the nested directories of
modules/org/jboss/as/product/XXX [module.xml specifies it, but there
will only be one]
4. Parse the values

--
Jason T. Greene
JBoss AS Lead / EAP Platform Architect
JBoss, a division of Red Hat
_______________________________________________
jboss-as7-dev mailing list
[hidden email]
https://lists.jboss.org/mailman/listinfo/jboss-as7-dev
Reply | Threaded
Open this post in threaded view
|

Re: Question about recently resolved branding issue

Max Rydahl Andersen
>> Can tools implement the same algorithm?
>
> This is what it would need to do:
>
> 1. Look for bin/product.conf
> 2. If found read it, format is slot=XXX (eap, soa-p, etc)
> 3. Look for a MANIFEST.MF file in one of the nested directories of
> modules/org/jboss/as/product/XXX [module.xml specifies it, but there
> will only be one]
> 4. Parse the values

Excellent - just what I needed :)

I've added links/text to https://issues.jboss.org/browse/AS7-1807 for future reference.

Thanks and kudos for the wolf friendly naming/non-overlaps ;)
/max
http://about.me/maxandersen




_______________________________________________
jboss-as7-dev mailing list
[hidden email]
https://lists.jboss.org/mailman/listinfo/jboss-as7-dev