Trimming the fat of the build & testsuite

classic Classic list List threaded Threaded
6 messages Options
Reply | Threaded
Open this post in threaded view
|

Trimming the fat of the build & testsuite

Tomaž Cerar-2
Hey guys,


As initial work on trimming our IO usage by testsuite and build,
I've send https://github.com/wildfly/wildfly-core/pull/2880
which changes wildfly-core to never produce "inflated" build/distro with jars present.
But rather uses thin server provisioning (module.xml entries point to maven GAV)

As part of this work, "dist" folder is now used for just that, for distribution and noting else.
So unless build is invoked with -Drelease which is something that is done as part of release process, "dist" folder will be empty and wont produce anything.

Sever for testing is still present in "build" directory as it always was.

This was done to reduce unnecessary IO work and producing multiple server builds without need for them.

I am sending this mail mostly as FYI that further work on this is going to happen, in core and in full, and such changes might clash with some poeple's workflows, where they are used to expect server dist to be in "dist" folder but it is not there yet.

--
tomaz

 

_______________________________________________
wildfly-dev mailing list
[hidden email]
https://lists.jboss.org/mailman/listinfo/wildfly-dev
Reply | Threaded
Open this post in threaded view
|

Re: Trimming the fat of the build & testsuite

Scott Marlow
Thanks for the heads up, the -Drelease option will be helpful for TCK
testing, so thanks also for adding that option!

On Fri, Oct 20, 2017 at 8:47 AM, Tomaž Cerar <[hidden email]> wrote:

> Hey guys,
>
>
> As initial work on trimming our IO usage by testsuite and build,
> I've send https://github.com/wildfly/wildfly-core/pull/2880
> which changes wildfly-core to never produce "inflated" build/distro with
> jars present.
> But rather uses thin server provisioning (module.xml entries point to maven
> GAV)
>
> As part of this work, "dist" folder is now used for just that, for
> distribution and noting else.
> So unless build is invoked with -Drelease which is something that is done as
> part of release process, "dist" folder will be empty and wont produce
> anything.
>
> Sever for testing is still present in "build" directory as it always was.
>
> This was done to reduce unnecessary IO work and producing multiple server
> builds without need for them.
>
> I am sending this mail mostly as FYI that further work on this is going to
> happen, in core and in full, and such changes might clash with some poeple's
> workflows, where they are used to expect server dist to be in "dist" folder
> but it is not there yet.
>
> --
> tomaz
>
>
>
> _______________________________________________
> wildfly-dev mailing list
> [hidden email]
> https://lists.jboss.org/mailman/listinfo/wildfly-dev

_______________________________________________
wildfly-dev mailing list
[hidden email]
https://lists.jboss.org/mailman/listinfo/wildfly-dev
Reply | Threaded
Open this post in threaded view
|

Re: Trimming the fat of the build & testsuite

Darran Lofthouse
Does -Drelease just populate the dist folders or does it do anything else as well?

On Sat, 21 Oct 2017 at 02:33 Scott Marlow <[hidden email]> wrote:
Thanks for the heads up, the -Drelease option will be helpful for TCK
testing, so thanks also for adding that option!

On Fri, Oct 20, 2017 at 8:47 AM, Tomaž Cerar <[hidden email]> wrote:
> Hey guys,
>
>
> As initial work on trimming our IO usage by testsuite and build,
> I've send https://github.com/wildfly/wildfly-core/pull/2880
> which changes wildfly-core to never produce "inflated" build/distro with
> jars present.
> But rather uses thin server provisioning (module.xml entries point to maven
> GAV)
>
> As part of this work, "dist" folder is now used for just that, for
> distribution and noting else.
> So unless build is invoked with -Drelease which is something that is done as
> part of release process, "dist" folder will be empty and wont produce
> anything.
>
> Sever for testing is still present in "build" directory as it always was.
>
> This was done to reduce unnecessary IO work and producing multiple server
> builds without need for them.
>
> I am sending this mail mostly as FYI that further work on this is going to
> happen, in core and in full, and such changes might clash with some poeple's
> workflows, where they are used to expect server dist to be in "dist" folder
> but it is not there yet.
>
> --
> tomaz
>
>
>
> _______________________________________________
> wildfly-dev mailing list
> [hidden email]
> https://lists.jboss.org/mailman/listinfo/wildfly-dev

_______________________________________________
wildfly-dev mailing list
[hidden email]
https://lists.jboss.org/mailman/listinfo/wildfly-dev

_______________________________________________
wildfly-dev mailing list
[hidden email]
https://lists.jboss.org/mailman/listinfo/wildfly-dev
Reply | Threaded
Open this post in threaded view
|

Re: Trimming the fat of the build & testsuite

Tomaž Cerar-2
> Does -Drelease just populate the dist folders or does it do anything else as well?

-Drelease populates dist folder and also produces .zip & tar.gz "distro" of wildfly core.

Without this flag, "dist" folder stays completely empty.

On Mon, Oct 23, 2017 at 10:28 AM, Darran Lofthouse <[hidden email]> wrote:
Does -Drelease just populate the dist folders or does it do anything else as well?


On Sat, 21 Oct 2017 at 02:33 Scott Marlow <[hidden email]> wrote:
Thanks for the heads up, the -Drelease option will be helpful for TCK
testing, so thanks also for adding that option!

On Fri, Oct 20, 2017 at 8:47 AM, Tomaž Cerar <[hidden email]> wrote:
> Hey guys,
>
>
> As initial work on trimming our IO usage by testsuite and build,
> I've send https://github.com/wildfly/wildfly-core/pull/2880
> which changes wildfly-core to never produce "inflated" build/distro with
> jars present.
> But rather uses thin server provisioning (module.xml entries point to maven
> GAV)
>
> As part of this work, "dist" folder is now used for just that, for
> distribution and noting else.
> So unless build is invoked with -Drelease which is something that is done as
> part of release process, "dist" folder will be empty and wont produce
> anything.
>
> Sever for testing is still present in "build" directory as it always was.
>
> This was done to reduce unnecessary IO work and producing multiple server
> builds without need for them.
>
> I am sending this mail mostly as FYI that further work on this is going to
> happen, in core and in full, and such changes might clash with some poeple's
> workflows, where they are used to expect server dist to be in "dist" folder
> but it is not there yet.
>
> --
> tomaz
>
>
>
> _______________________________________________
> wildfly-dev mailing list
> [hidden email]
> https://lists.jboss.org/mailman/listinfo/wildfly-dev

_______________________________________________
wildfly-dev mailing list
[hidden email]
https://lists.jboss.org/mailman/listinfo/wildfly-dev


_______________________________________________
wildfly-dev mailing list
[hidden email]
https://lists.jboss.org/mailman/listinfo/wildfly-dev
Reply | Threaded
Open this post in threaded view
|

Re: Trimming the fat of the build & testsuite

Sanne Grinovero
Was it worth it? 

On 23 Oct 2017 15:01, "Tomaž Cerar" <[hidden email]> wrote:
> Does -Drelease just populate the dist folders or does it do anything else as well?

-Drelease populates dist folder and also produces .zip & tar.gz "distro" of wildfly core.

Without this flag, "dist" folder stays completely empty.

On Mon, Oct 23, 2017 at 10:28 AM, Darran Lofthouse <[hidden email]> wrote:
Does -Drelease just populate the dist folders or does it do anything else as well?


On Sat, 21 Oct 2017 at 02:33 Scott Marlow <[hidden email]> wrote:
Thanks for the heads up, the -Drelease option will be helpful for TCK
testing, so thanks also for adding that option!

On Fri, Oct 20, 2017 at 8:47 AM, Tomaž Cerar <[hidden email]> wrote:
> Hey guys,
>
>
> As initial work on trimming our IO usage by testsuite and build,
> I've send https://github.com/wildfly/wildfly-core/pull/2880
> which changes wildfly-core to never produce "inflated" build/distro with
> jars present.
> But rather uses thin server provisioning (module.xml entries point to maven
> GAV)
>
> As part of this work, "dist" folder is now used for just that, for
> distribution and noting else.
> So unless build is invoked with -Drelease which is something that is done as
> part of release process, "dist" folder will be empty and wont produce
> anything.
>
> Sever for testing is still present in "build" directory as it always was.
>
> This was done to reduce unnecessary IO work and producing multiple server
> builds without need for them.
>
> I am sending this mail mostly as FYI that further work on this is going to
> happen, in core and in full, and such changes might clash with some poeple's
> workflows, where they are used to expect server dist to be in "dist" folder
> but it is not there yet.
>
> --
> tomaz
>
>
>
> _______________________________________________
> wildfly-dev mailing list
> [hidden email]
> https://lists.jboss.org/mailman/listinfo/wildfly-dev

_______________________________________________
wildfly-dev mailing list
[hidden email]
https://lists.jboss.org/mailman/listinfo/wildfly-dev


_______________________________________________
wildfly-dev mailing list
[hidden email]
https://lists.jboss.org/mailman/listinfo/wildfly-dev

_______________________________________________
wildfly-dev mailing list
[hidden email]
https://lists.jboss.org/mailman/listinfo/wildfly-dev
Reply | Threaded
Open this post in threaded view
|

Re: Trimming the fat of the build & testsuite

Brian Stansberry
In reply to this post by Tomaž Cerar-2
AFAICT currently (i.e. before this change), the normal dist module build (i.e. no -Drelease) didn't do anything different from the 'build' module besides creating a fat server, except [1]. So I'm ok with skipping that.  I'll just change my normal

$ dist/target/wildfly-whatever-SNAPSHOT/bin/standalone.sh

to 

$ build/target/wildfly-whatever-SNAPSHOT/bin/standalone.sh

[1] In full WildFly the dist module runs the maven-verifier-plugin. We'll need to move that to 'build' as I don't want it only run when we're about to release. I believe all the existing verifications should work just fine from build, except for this one, which IMO should be removed anyway, as it's not checking any contract we support:


    <file>
      <location>target/${server.output.dir.prefix}-${project.version}/modules/system/layers/base/org/jboss/as/server/main/wildfly-server-${version.org.wildfly.core}.jar</location>
      <exists>true</exists>
    </file>

Rob -- can you confirm that JBDS doesn't really need to check the contents of the server module any more? AIUI doing that was just a workaround in some prior releases and isn't relevant with the latest releases.


On Fri, Oct 20, 2017 at 7:47 AM, Tomaž Cerar <[hidden email]> wrote:
Hey guys,


As initial work on trimming our IO usage by testsuite and build,
I've send https://github.com/wildfly/wildfly-core/pull/2880
which changes wildfly-core to never produce "inflated" build/distro with jars present.
But rather uses thin server provisioning (module.xml entries point to maven GAV)

As part of this work, "dist" folder is now used for just that, for distribution and noting else.
So unless build is invoked with -Drelease which is something that is done as part of release process, "dist" folder will be empty and wont produce anything.

Sever for testing is still present in "build" directory as it always was.

This was done to reduce unnecessary IO work and producing multiple server builds without need for them.

I am sending this mail mostly as FYI that further work on this is going to happen, in core and in full, and such changes might clash with some poeple's workflows, where they are used to expect server dist to be in "dist" folder but it is not there yet.

--
tomaz

 

_______________________________________________
wildfly-dev mailing list
[hidden email]
https://lists.jboss.org/mailman/listinfo/wildfly-dev



--
Brian Stansberry
Manager, Senior Principal Software Engineer
Red Hat

_______________________________________________
wildfly-dev mailing list
[hidden email]
https://lists.jboss.org/mailman/listinfo/wildfly-dev