module usability issue? or intended?

classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

module usability issue? or intended?

Bill Burke
I wanted to add a custom LoginModule.  To have the class visible, I had
to add my jars to the picketbox module.

Originally, I tried the intuitive approach (well, intuitive to me), of
creating a new module for my custom jars, and adding a dependency to
these jars within the picketbox module.  This did not work.  Is it
supposed to?  If not, why?

I'm just trying to understand the logic here.


--
Bill Burke
JBoss, a division of Red Hat
http://bill.burkecentral.com
_______________________________________________
jboss-as7-dev mailing list
[hidden email]
https://lists.jboss.org/mailman/listinfo/jboss-as7-dev
Reply | Threaded
Open this post in threaded view
|

Re: module usability issue? or intended?

Brian Stansberry
Just a guess, but a module does not export its dependencies by default.
You have to add attribute export="true" to export the entire dependent
module, or use child "exports" elements to export particular classes.

On 7/6/11 8:53 AM, Bill Burke wrote:

> I wanted to add a custom LoginModule.  To have the class visible, I had
> to add my jars to the picketbox module.
>
> Originally, I tried the intuitive approach (well, intuitive to me), of
> creating a new module for my custom jars, and adding a dependency to
> these jars within the picketbox module.  This did not work.  Is it
> supposed to?  If not, why?
>
> I'm just trying to understand the logic here.
>
>


--
Brian Stansberry
Principal Software Engineer
JBoss by Red Hat
_______________________________________________
jboss-as7-dev mailing list
[hidden email]
https://lists.jboss.org/mailman/listinfo/jboss-as7-dev
Reply | Threaded
Open this post in threaded view
|

Re: module usability issue? or intended?

jtgreene
Administrator
Bah this is all wrong (and inconsistent)! All Bill should have to do is
either a) deploy security plugin deployment or b) add a new security
extension module and reference it from the domain configuration. He
shouldn't have to muck with the picketlink module descriptors. I'll
create an issue for this.

On 7/6/11 9:17 AM, Brian Stansberry wrote:

> Just a guess, but a module does not export its dependencies by default.
> You have to add attribute export="true" to export the entire dependent
> module, or use child "exports" elements to export particular classes.
>
> On 7/6/11 8:53 AM, Bill Burke wrote:
>> I wanted to add a custom LoginModule.  To have the class visible, I had
>> to add my jars to the picketbox module.
>>
>> Originally, I tried the intuitive approach (well, intuitive to me), of
>> creating a new module for my custom jars, and adding a dependency to
>> these jars within the picketbox module.  This did not work.  Is it
>> supposed to?  If not, why?
>>
>> I'm just trying to understand the logic here.
>>
>>
>
>


--
Jason T. Greene
JBoss, a division of Red Hat
_______________________________________________
jboss-as7-dev mailing list
[hidden email]
https://lists.jboss.org/mailman/listinfo/jboss-as7-dev
Reply | Threaded
Open this post in threaded view
|

Re: module usability issue? or intended?

Rémy Maucherat
On Wed, 2011-07-06 at 09:35 -0500, Jason T. Greene wrote:
> Bah this is all wrong (and inconsistent)! All Bill should have to do is
> either a) deploy security plugin deployment or b) add a new security
> extension module and reference it from the domain configuration. He
> shouldn't have to muck with the picketlink module descriptors. I'll
> create an issue for this.

Ok, I would like some clarification then.

When deploying a web extension component (like a web valve, listener,
etc), I expect right now the user to create a module, then declare that
it will load his component class from the specified module (but without
having to edit the web module to add the newly added module as a
dependency). Is that ok ?

--
Remy Maucherat <[hidden email]>
Red Hat Inc

_______________________________________________
jboss-as7-dev mailing list
[hidden email]
https://lists.jboss.org/mailman/listinfo/jboss-as7-dev
Reply | Threaded
Open this post in threaded view
|

Re: module usability issue? or intended?

David M. Lloyd
On 07/06/2011 09:58 AM, Remy Maucherat wrote:

> On Wed, 2011-07-06 at 09:35 -0500, Jason T. Greene wrote:
>> Bah this is all wrong (and inconsistent)! All Bill should have to do is
>> either a) deploy security plugin deployment or b) add a new security
>> extension module and reference it from the domain configuration. He
>> shouldn't have to muck with the picketlink module descriptors. I'll
>> create an issue for this.
>
> Ok, I would like some clarification then.
>
> When deploying a web extension component (like a web valve, listener,
> etc), I expect right now the user to create a module, then declare that
> it will load his component class from the specified module (but without
> having to edit the web module to add the newly added module as a
> dependency). Is that ok ?

Generally no - the user should never be required to create a static
module (though they should always have that option if they want to) in
order to use deployment features, at least not if we can avoid it.  In
this case it might be best to look for the class in the deployment
unless an explicit module name is given.

--
- DML
_______________________________________________
jboss-as7-dev mailing list
[hidden email]
https://lists.jboss.org/mailman/listinfo/jboss-as7-dev